Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh] updated 3 files in content/zh/docs/contribute/ #33626

Merged
merged 1 commit into from
May 13, 2022
Merged

[zh] updated 3 files in content/zh/docs/contribute/ #33626

merged 1 commit into from
May 13, 2022

Conversation

windsonsea
Copy link
Member

@windsonsea windsonsea commented May 12, 2022

Accepted the localization task #33474 from @tengqm. Added translations and updated some minor errors.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 12, 2022
@k8s-ci-robot k8s-ci-robot added the language/zh Issues or PRs related to Chinese language label May 12, 2022
@k8s-ci-robot k8s-ci-robot requested a review from chenxuc May 12, 2022 05:33
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label May 12, 2022
@netlify
Copy link

netlify bot commented May 12, 2022

Deploy Preview for kubernetes-io-main-staging ready!

Name Link
🔨 Latest commit b9c0f40
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/627e0e7b17eafa0009059549
😎 Deploy Preview https://deploy-preview-33626--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

content/zh/docs/contribute/new-content/_index.md Outdated Show resolved Hide resolved
content/zh/docs/contribute/new-content/_index.md Outdated Show resolved Hide resolved
content/zh/docs/contribute/new-content/_index.md Outdated Show resolved Hide resolved
content/zh/docs/contribute/new-content/_index.md Outdated Show resolved Hide resolved
content/zh/docs/contribute/participate/pr-wranglers.md Outdated Show resolved Hide resolved
content/zh/docs/contribute/participate/pr-wranglers.md Outdated Show resolved Hide resolved
content/zh/docs/contribute/participate/pr-wranglers.md Outdated Show resolved Hide resolved
content/zh/docs/contribute/participate/pr-wranglers.md Outdated Show resolved Hide resolved
content/zh/docs/contribute/participate/pr-wranglers.md Outdated Show resolved Hide resolved
content/zh/docs/contribute/new-content/_index.md Outdated Show resolved Hide resolved
content/zh/docs/contribute/new-content/_index.md Outdated Show resolved Hide resolved
content/zh/docs/contribute/new-content/_index.md Outdated Show resolved Hide resolved
content/zh/docs/contribute/new-content/_index.md Outdated Show resolved Hide resolved
content/zh/docs/contribute/new-content/_index.md Outdated Show resolved Hide resolved
content/zh/docs/contribute/participate/pr-wranglers.md Outdated Show resolved Hide resolved
content/zh/docs/contribute/participate/pr-wranglers.md Outdated Show resolved Hide resolved
@windsonsea windsonsea changed the title updated 3 files in content/zh/docs/contribute/new-content [zh] updated 3 files in content/zh/docs/contribute/ May 12, 2022
@tengqm
Copy link
Contributor

tengqm commented May 12, 2022

Thanks.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2022
@windsonsea
Copy link
Member Author

Thanks. /approve

do we need call one more reviewer to give a /lgtm?

@tengqm
Copy link
Contributor

tengqm commented May 13, 2022

Thanks. /approve

do we need call one more reviewer to give a /lgtm?

Please be patient. Other reviewers will review this soon.

content/zh/docs/contribute/participate/pr-wranglers.md Outdated Show resolved Hide resolved
content/zh/docs/contribute/participate/pr-wranglers.md Outdated Show resolved Hide resolved
批准变更时,可以登记一个新的 Issue 来解决文档风格问题。
你通常可以将这些风格修复问题标记为 `good first issue`。
- 将风格修复事项作为 `good first issue` 可以很好地确保向新加入的贡献者分派一些比较简单的任务,
这有助于接纳新的贡献者。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
这有助于接纳新的贡献者
这有助于帮助新的贡献者

翻译为 “帮助”更符合英文原意。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

咦,有助于 - 帮助,会不会有点重复了

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对,我又看了一下,有助于 - 帮助,是有点重复。

@mengjiao-liu
Copy link
Member

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9d45321dfc852026bbb5f9f9d9e57d35681caf6b

@k8s-ci-robot k8s-ci-robot merged commit cd64165 into kubernetes:main May 13, 2022
@windsonsea
Copy link
Member Author

/lgtm Thanks!

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants